Hide notification when a user forks a repo - #119
Merged
Merged
Conversation
Contributor
|
👍 @paulmolluzzo Do you think you could unify all feed item |
paulmolluzzo
force-pushed
the
hide-forked-repo-news
branch
2 times, most recently
from
March 30, 2016 18:34
a5a6907 to
2bb8290
Compare
Contributor
Author
|
OK, I pushed up a change that combined them all. Let me know if I messed up when moving around pieces. |
| create a branch | ||
| deletes a branch | ||
| adds someone as a collaborator | ||
| forks a repo |
Contributor
There was a problem hiding this comment.
Could we use consistent present imperative wording?
push to a branch
create a branch
delete a branch
add someone as a collaborator
fork a repo
Contributor
Author
There was a problem hiding this comment.
LOL, don't mean to argue, but they should all be past tense. They happened already, so we got a notification. 😉
Also going to add !important a la #22 (comment)
paulmolluzzo
force-pushed
the
hide-forked-repo-news
branch
from
March 30, 2016 18:42
2bb8290 to
2d7661b
Compare
Contributor
Author
|
All past tense: Using |
Contributor
|
LGTM from me. I don't want to get into more details when the goal is to first fix #113. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #113 by hiding the notification when someone forks another repo. ✌️