Improve branch name assignment - #21
Closed
paulmolluzzo wants to merge 5 commits into
Closed
paulmolluzzo wants to merge 5 commits into
paulmolluzzo wants to merge 5 commits into
Conversation
… name of forked repo
| // if there are two parts the first part is the username | ||
| if (parts.length > 1) { | ||
| let username = parts.eq(0).text(); | ||
| } |
Member
There was a problem hiding this comment.
I'm confused, isn't that the same as on line 26-29?
See: d17a137
Contributor
Author
There was a problem hiding this comment.
No, it's not the same exactly. My change will use the owner's name in the URL. The master branch (without this update) will use the current user's username.
Master:
This branch:
Contributor
Author
|
Sorry for the sloppiness here. 😞 |
Member
|
LGTM. @hkdobrev ? (i will squash the commits when merging) |
Contributor
|
I haven't noticed this before, but indeed I've just reproduced the problem and could verify this fixes it. I'd say the code changes are an improvement as well. LGTM 💫 |
Member
|
Good stuff @paulmolluzzo :) |
Contributor
Author
|
🙏 |
This was referenced Sep 21, 2020
This was referenced Mar 23, 2021
This was referenced May 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a red herring that I tried to murder with regex. Sorry for the mess.
Fixes #18.
Basically, in your own repo the
branchvar assignment was incorrect, leading to bad URLs in the linkified repos at the top of a PR. This PR should be evidence of the fix.