Conversation
4c49f97 to
95b80a5
Compare
Is it? The Releases tab points to /releases while that section can point straight to the latest release at /releases/v2.3.4 However… /releases will most likely show the latest release first, so this may be right. |
The section header and the '+ x releases' link at the bottom of the section, both point to
which is my case for the argument that the section is redundant |
95b80a5 to
b37b8bc
Compare
Signed-off-by: shine <[email protected]>
b37b8bc to
3d01802
Compare
|
Why hide it instead of removing it? |
|
I was thinking in terms of when the sidebar becomes sticky ( #3349 ) and the view has scrolled down quite a bit. There, one would not have quick access to the Releases Tab and would prefer to see the Releases section in the sticky sidebar. At that point, if we wanted to re-activate the section, we would not be able to if the section was completely removed. I was thinking for the future. Also, there maybe other features or ( even external extensions ) that query the DOM for the Releases section and not finding it would break them. After all, we are not removing an empty section without any content, we are removing a section that is seemingly redundant when the Releases Tab is in view. That information could still be useful when the Releases Tab is not in view. |
This is a good reason
This is not. The sticky sidebar depends on the height, so we can't make it taller once it becomes sticky, because it would invalidate the calculation. |
Co-authored-by: Federico <[email protected]>
🎉 🙌 |
|
I think this should be mentioned in the description of |
I agree, I wish this was behind a feature flag itself. I did use this more than I thought it would, to directly go to the latest release which often contains the release notes/change log (like this repo). Is there any possibility this would get its own feature flag? I understand this is a heavily opinionated set of refinements so of course if there's no chance for that, I'll just disable |
|
What if we merged https://github.com/sindresorhus/refined-github/blob/master/source/features/hide-empty-meta.tsx |
The 'Releases' section in the 'Refreshed Repository' design sidebar is redundant when there is already the releases-tab.
This change removes the 'Releases' section from the sidebar.
I'm not sure whether this has been discussed before ( I did dig through some old issues, but could not find any ), but there is one direct link to the latest release that goes away with the section.
I usually find myself either navigating directly to
/releases/latestor simply going to the main Releases page and referring to the latest release. I do not know if people use the latest release link as often. But the remaining information is already on the releases-tab.LINKED ISSUES:
None
TEST URLS:
Any repository root page
SCREENSHOT:
Before :

After :
