Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add git-checkout-pr feature - #3596

Merged
fregante merged 54 commits into
refined-github:masterfrom
yakov116:check-it-out
Nov 3, 2020
Merged

Add git-checkout-pr feature#3596
fregante merged 54 commits into
refined-github:masterfrom
yakov116:check-it-out

Conversation

@yakov116

@yakov116 yakov116 commented Sep 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

  1. LINKED ISSUES:
    Closes Can RG recommend me the command to fetch a PR locally? #2767

  2. TEST URLS:
    Remote URL: Mark peer dependencies as optional twbs/bootstrap#30329
    Upstream URL: karma: stop excluding polyfill.js from istanbul twbs/bootstrap#30740
    Own PR: undefined
    Local PR: I and I am collaborator, I removed the exclude for merged PR from it. You can probably find a PR since you are a collaborator in more repositories then me :).

  3. SCREENSHOT:
    image

@yakov116
yakov116 requested a review from fregante September 25, 2020 16:00
fregante
fregante requested changes Sep 27, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116

This comment has been minimized.

Sign in to view
@yakov116
yakov116 requested a review from fregante September 29, 2020 23:51
yakov116
yakov116 commented Sep 29, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
fregante
fregante reviewed Sep 30, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
yakov116
yakov116 commented Oct 1, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116

This comment has been minimized.

Sign in to view
FloEdelmann
FloEdelmann reviewed Oct 12, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116
yakov116 marked this pull request as ready for review October 20, 2020 13:14
fregante
fregante approved these changes Oct 20, 2020
View reviewed changes
Comment thread readme.md Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
FloEdelmann
FloEdelmann reviewed Oct 20, 2020
View reviewed changes
Comment thread readme.md Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116

yakov116 commented Oct 25, 2020

Copy link
Copy Markdown
Member Author

Draft until after lint PR is merged

fregante
fregante reviewed Oct 26, 2020
View reviewed changes
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116
yakov116 marked this pull request as ready for review October 26, 2020 22:49
@yakov116

yakov116 commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

All working with isLocalPR dropped
I tested on this PR (My own)
webpack/webpack#11831
webpack/webpack#11824

I don't have a collaborator with a local PR to test on (but I manually tested on a merged and it worked)

fregante
fregante reviewed Oct 27, 2020
View reviewed changes

@fregante fregante left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic is fine now, but I haven’t tested all the cases. Can you test them and include your testing links? (Of course they’ll be related to you as the viewer)

Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx
Comment thread source/features/git-checkout-pr.tsx Outdated
Comment thread source/features/git-checkout-pr.tsx Outdated
@yakov116

yakov116 commented Oct 27, 2020

Copy link
Copy Markdown
Member Author

I think the logic is fine now, but I haven’t tested all the cases. Can you test them and include your testing links? (Of course they’ll be related to you as the viewer)

I tested them all. I keep posting links but they keep getting merged 😿 .

@fregante

fregante commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

What I do is find old PRs on large, famous repos so there’s no chance that they get merged quickly.

@yakov116

yakov116 commented Oct 27, 2020

Copy link
Copy Markdown
Member Author

What I do is find old PRs on large, famous repos so there’s no chance that they get merged quickly.

Like octoicon 😆 ?

@yakov116

yakov116 commented Oct 27, 2020

Copy link
Copy Markdown
Member Author

Remote URL: twbs/bootstrap#30329
Upstream URL: twbs/bootstrap#30740
Own PR: undefined
Local PR: I and I am collaborator, I removed the exclude for merged PR from it. You can probably find a PR since you are a collaborator in more repositories then me :).

@yakov116
yakov116 requested a review from fregante October 27, 2020 22:34
@yakov116

yakov116 commented Oct 28, 2020

Copy link
Copy Markdown
Member Author

@fregante do you mind to review? It would be great to have this ship tomorrow!

@cheap-glitch cheap-glitch mentioned this pull request Oct 31, 2020
Merged
@yakov116

yakov116 commented Nov 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@fregante now is the perfect time to review this as we both have PR's open (from local branchs)

@fregante

fregante commented Nov 3, 2020

Copy link
Copy Markdown
Member

I'll extract the remote logic here because the review comment is easily lost:

It's kinda complicated and needs a little guessing, actually. Examples:

  • as a collaborator of this repo, origin points to this repo
  • you're also a collaborator of this repo, but I don't think that origin points to this repo yet since you still open

In short, if I see a PR opened from a branch here, I can pull origin, but if you see it, you will pull upstream, I'm guessing.

I think it varies based on the viewer and on the head repo:

viewer ⬇️ head:
viewer’s own repo 		head:
owner’s repo 		head:
other repo
owner origin $author
collaborator origin origin or upstream $author
3rd party origin origin or upstream $author

Notes:

  • there are 2 "or"s, but I crossed the less likely one; we can probably use the other option in our logic
  • when it's origin, there shouldn't be a git remote add

@fregante
fregante merged commit 86ed023 into refined-github:master Nov 3, 2020
@yakov116
yakov116 deleted the check-it-out branch November 11, 2020 13:32
@yakov116 yakov116 mentioned this pull request Nov 13, 2020
Merged
@fregante fregante mentioned this pull request Apr 2, 2022
Closed
@fregante fregante mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann left review comments
@sindresorhus sindresorhus Awaiting requested review from sindresorhus
@fregante fregante Awaiting requested review from fregante

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can RG recommend me the command to fetch a PR locally?

3 participants

@yakov116 @fregante @FloEdelmann