Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fully restore set-default-repositories-type-to-sources - #3749

Merged
fregante merged 15 commits into
refined-github:masterfrom
cheap-glitch:fix-repos-type-to-source-in-dropdown
Dec 27, 2020
Merged

Fully restore set-default-repositories-type-to-sources#3749
fregante merged 15 commits into
refined-github:masterfrom
cheap-glitch:fix-repos-type-to-source-in-dropdown

Conversation

@cheap-glitch

@cheap-glitch cheap-glitch commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

Thanks for contributing! 🍄

  1. LINKED ISSUES: Fixes set-default-repositories-type-to-sources not working #3733

  2. TEST URLS:

    1. Click your "user dropdown" (top-right corner of every page)
    2. Click "Your repositories"

Should we also take the opportunity to drop the selectors used for the old layout?

Comment thread source/features/set-default-repositories-type-to-sources.tsx Outdated
@fregante fregante added the bug label Nov 21, 2020
@cheap-glitch

Copy link
Copy Markdown
Contributor Author

Replaced observe with elementReady as requested. Also, to reiterate:

Should we also take the opportunity to drop the selectors used for the old layout?

(or maybe it should be done in a separate PR?)

@fregante

Copy link
Copy Markdown
Member

Should we also take the opportunity to drop the selectors used for the old layout?

The current PR code is fine. We only need to drop the old code when it requires active support, which usually doesn't since we kept them separate (or it's just a selector like in this case).

@fregante

Copy link
Copy Markdown
Member

Remember to use Fixes #123456789 or else the original issue you're fixing will remain open. I updated your post

Comment thread source/features/set-default-repositories-type-to-sources.tsx Outdated
@fregante
fregante marked this pull request as draft November 22, 2020 04:01
@cheap-glitch

Copy link
Copy Markdown
Contributor Author

I went ahead and made a more generic version of https://github.com/sindresorhus/refined-github/blob/f9d8b7a5a402e19b0cb16fd937e0f19c43a6e699/source/github-events/on-pr-file-load.ts named on-fragment-load.ts to test in the feature. It works great, although I'm not too happy with the selector (the targeted include-fragment element has no classes attached to it afaik).

Next step I guess would be to remove on-pr-file-load and use the more generic version in show-whitespace and hidden-review-comments-indicator?

Comment thread source/features/set-default-repositories-type-to-sources.tsx Outdated
@cheap-glitch
cheap-glitch marked this pull request as ready for review November 30, 2020 12:01

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM

@fregante fregante changed the title Fix set-default-repositories-type-to-sources Restore set-default-repositories-type-to-sources in header user dropdown Dec 15, 2020
Comment thread source/features/set-default-repositories-type-to-sources.tsx Outdated
@fregante

Copy link
Copy Markdown
Member

I’d still like it to be its own separate function so it can be reused

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM 😃

@fregante

Copy link
Copy Markdown
Member

Now it also fixes deprioritize-marketplace-link

@fregante fregante changed the title Restore set-default-repositories-type-to-sources in header user dropdown Fully restore set-default-repositories-type-to-sources Dec 27, 2020
@fregante
fregante merged commit 80063c3 into refined-github:master Dec 27, 2020
@cheap-glitch
cheap-glitch deleted the fix-repos-type-to-source-in-dropdown branch December 27, 2020 09:03
@fregante

Copy link
Copy Markdown
Member

I opened a couple of issues related to this PR: #3908 #3898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

set-default-repositories-type-to-sources not working

3 participants