Drop cycle-lists-with-keyboard-shortcuts feature - #3777
Conversation
cycle-lists-with-keyboard-shortcutscycle-lists-with-keyboard-shortcuts feature
| - [Blog post](https://github.com/sindresorhus/refined-github/pull/3015): [Makes it easier to tell apart commits added to the current PR versus plain commits that reference the PR.](https://user-images.githubusercontent.com/1402241/64478939-398b0a80-d1da-11e9-8c6a-bb98668cb78c.gif) | ||
| - [Blog post](https://github.blog/changelog/2020-06-23-design-updates-to-repositories-and-github-ui/): [Widens the discussion search box.](https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png) | ||
|
|
||
| - [Blog post](https://github.com/sindresorhus/refined-github/issues/3776): [Allows the <kbd>↑</kbd> and <kbd>↓</kbd> keys to cycle "popover lists" (labels, milestones, etc).](https://user-images.githubusercontent.com/37769974/59158786-6fd2c400-8add-11e9-9db1-db80186fa6ea.gif) |
There was a problem hiding this comment.
“Blog post” is starting to not make sense. Either we drop the link or we change the wording. It’s not particularly useful... I mean the whole list isn’t super useful either.
What if we replace it with a PR search link that points to every PR with “drop” in the title? We’ll also have to update some old PRs that don’t use the word.
There was a problem hiding this comment.
Agree. This PR or a lint?
There was a problem hiding this comment.
I was thinking the same. I was looking at the changes and when I say "blog post" I was confused.
What about simply using a label like adopted by github? So what you could use the link:
https://github.com/sindresorhus/refined-github/pulls?q=is%3Apr+is%3Aclosed+label%3A%22adopted+by+github%22
There was a problem hiding this comment.
What about simply using a label
We could use a more generic dropped feature label, but we don't really need another label since the PR title should include that keyword already.
Agree. This PR or a lint?
This PR can just avoid making changes to that section. In a lint you could drop the list and if you have time maybe also track down any PRs that don't have the "Drop" keyword in the title
LINKED ISSUES:
Closes Drop
cycle-lists-with-keyboard-shortcuts#3776TEST URLS:
None
SCREENSHOT:
None