Fix hide-zero-packages on repo roots - #3784
Closed
cheap-glitch wants to merge 1 commit into
Closed
Conversation
fregante
reviewed
Dec 3, 2020
| async function init(): Promise<void | false> { | ||
| const packagesTab = await elementReady([ | ||
| '.BorderGrid-cell a[href$="/packages"]', // `isRepoRoot` | ||
| '.BorderGrid-cell a[href*="/packages"]', // `isRepoRoot` |
Member
There was a problem hiding this comment.
This would also catch any repo that has the word “packages” in it, doesn’t it?
Contributor
Author
There was a problem hiding this comment.
You're right, didn't think about that. Then how about
Suggested change
| '.BorderGrid-cell a[href*="/packages"]', // `isRepoRoot` | |
| '.BorderGrid-cell a[href*="/packages?"]', // `isRepoRoot` |
Contributor
Author
|
Closing because of #3783 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 🍄
LINKED ISSUES: None
TEST URLS: https://github.com/sindresorhus/refined-github
This feature broke because the URL of the "Packages" links now ends with some query parameters (e.g.
https://github.com/users/sindresorhus/packages?repo_name=refined-github)