Fix new-repo-disable-projects-and-wiki feature - #3794
Merged
yakov116 merged 2 commits intoDec 9, 2020
Merged
Conversation
Member
|
Just pass a slash instead of an empty string in the feature |
Contributor
Author
This won't work. We want |
Member
|
Oh your right misunderstood the issue |
fregante
reviewed
Dec 7, 2020
Co-authored-by: Federico <[email protected]>
new-repo-disable-projects-and-wikinew-repo-disable-projects-and-wiki feature
Member
|
Thanks @cheap-glitch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 馃崉
LINKED ISSUES: none
TEST URLS: https://github.com/new
The
new-repo-disable-projects-and-wikifeature was the only one passing an empty query string toapi.v3(), which caused a trailing slash to appear at the end of the URL and resulted in a 404 error.