Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix a couple of issues with GitHub Dark mode - #3801

Merged
fregante merged 3 commits into
refined-github:masterfrom
mcornella:patch-1
Dec 9, 2020
Merged

Fix a couple of issues with GitHub Dark mode#3801
fregante merged 3 commits into
refined-github:masterfrom
mcornella:patch-1

Conversation

@mcornella

@mcornella mcornella commented Dec 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

  1. LINKED ISSUES:
    Corrects some issues in Support for Github Darkmode #3798

  2. TEST URLS:
    Just the main dashboard (see while logged in).
    Also you need to have enabled Dark mode in Settings.

  3. SCREENSHOTS:

    With Dark mode (fixed)

    Before
    Before screenshot

    After
    After screenshot

    With Light mode (the same)

    Before
    Before screenshot

    After
    After screenshot

Tested via custom CSS, with the following snippet:

.dashboard .js-all-activity-header + div {
	background-color: var(--color-bg-canvas);
	border: 1px solid var(--color-border-primary);
}

@mcornella mcornella mentioned this pull request Dec 8, 2020
Closed
@yakov116 yakov116 added the bug label Dec 8, 2020
@fregante fregante mentioned this pull request Dec 8, 2020
Closed
@mcornella
mcornella marked this pull request as draft December 8, 2020 22:34
@mcornella mcornella changed the title Fix All Activity dashboard color in Dark mode Fix a couple of issues with GitHub Dark mode Dec 8, 2020
@mcornella
mcornella marked this pull request as ready for review December 8, 2020 23:23
@fregante
fregante merged commit ac5d9b4 into refined-github:master Dec 9, 2020
@fregante

fregante commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for both fixes! I’ll deploy this as a hotfix because it’s bothering a few people ✌️

@szepeviktor

szepeviktor commented Dec 9, 2020

Copy link
Copy Markdown

I still have some white ones

kép

Please advise

@kidonng

kidonng commented Dec 9, 2020

Copy link
Copy Markdown
Member

@szepeviktor Did you update Refined GitHub and clear your browser cache?

@szepeviktor

szepeviktor commented Dec 9, 2020

Copy link
Copy Markdown

Verzió 20.12.9

But my cache is still warm.

Clearing right now...

@szepeviktor

szepeviktor commented Dec 9, 2020

Copy link
Copy Markdown

Done.

kép

Still some white objects...

@kidonng

kidonng commented Dec 9, 2020

Copy link
Copy Markdown
Member

It should have round avatars:

image

There are probably some other extensions that caused this. You may need to test with a new browser profile.

@mcornella
mcornella deleted the patch-1 branch December 9, 2020 16:05
@szepeviktor

szepeviktor commented Dec 9, 2020

Copy link
Copy Markdown

You are right, it is daattali/oldschool-github-extension#39

I still want square everything but @sindresorhus denied it #3268

@refined-github refined-github locked as spam and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fregante fregante fregante approved these changes
@yakov116 yakov116 yakov116 approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcornella @fregante @szepeviktor @kidonng @yakov116