Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix parse-backticks in PR commit list and Compare page - #3812

Merged
fregante merged 3 commits into
refined-github:masterfrom
mcornella:fix/backticks-in-PR-commit-list
Dec 16, 2020
Merged

Fix parse-backticks in PR commit list and Compare page#3812
fregante merged 3 commits into
refined-github:masterfrom
mcornella:fix/backticks-in-PR-commit-list

Conversation

@mcornella

Copy link
Copy Markdown
Contributor
  1. LINKED ISSUES:
    None specifically, but these two comments: Support for Github Darkmode #3798 (comment), Further improvements to Dark mode #3806 (comment).

  2. TEST URLS:
    This PR with many commits.

  3. SCREENSHOT:

    Before After
    backticks in PR commit list - before backticks in PR commit list - after

I also fixed the way the :not(.rgh-backticks-already-parsed) pseudo-class is added to the selectors, in the case where multiple selectors are grouped in a single array item (see commit 2).

Comment thread source/features/parse-backticks.tsx Outdated
Comment thread source/features/parse-backticks.tsx Outdated
@fregante
fregante marked this pull request as draft December 15, 2020 02:02

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title could be updated

@fregante
fregante marked this pull request as ready for review December 16, 2020 04:41
@mcornella mcornella changed the title Fix parsing of backticks in PR conversation commit list Fix parse-backticks in PR commit list and Compare page Dec 16, 2020
@fregante
fregante merged commit ea04b4e into refined-github:master Dec 16, 2020
@mcornella
mcornella deleted the fix/backticks-in-PR-commit-list branch December 16, 2020 21:04
@fregante fregante mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants