Allow clean-dashboard to be disabled - #3817
Merged
yakov116 merged 1 commit intoDec 14, 2020
Merged
Conversation
Member
|
I don't think we should do this. We can provide the css to disable the feature. @fregante what's the policy? Are we no longer having css only features? |
Member
|
I don鈥檛 feel super strongly about that anymore, especially if the feature can鈥檛 be disabled with a couple of lines. Here for example it makes sense because the CSS applied is substantial so it can鈥檛 easily be undone. |
fregante
approved these changes
Dec 14, 2020
yakov116
approved these changes
Dec 14, 2020
clean-dashboardclean-dashboard to be disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 馃崉
LINKED ISSUES: Closes Let users disable
clean-dashboard聽#3816TEST URLS: Dashboard
SCREENSHOT: