Fix sync-pr-commit-title to work with GitHub's auto-merge - #3833
Merged
fregante merged 1 commit intoDec 27, 2020
Conversation
Member
|
Can you add some screenshots or gifs showing it in action? I don’t see the checkbox in your screenshots. i see however that “convert to draft” is in the wrong place |
Member
Author
|
I've made two gifs in this PR: OpenLightingProject/open-fixture-library#1651 Without fix (current master)
With fix (this PR)
Indeed, is that added by Refined GitHub? I thought that was a native GitHub feature they didn't consider 😄 Another issue you can see in the gifs is that auto-resizing textareas sometimes have zero height and only expand once you initially click into them. But both problems are rather minor and should be considered in another issue/PR. |
fregante
approved these changes
Dec 22, 2020
Member
|
Yeah the textarea bug is little old and needs fixing 😬 fregante/fit-textarea#8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3829.
Test URLs are quite specific… A PR that you can merge, where some branch restrictions are not met, and where auto-merge is enabled.
Please test both cases:
Auto-merge
Override restrictions and merge immediately
You don't need to actually merge the PR, just verify that this note appears when changing the commit title: