Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid embedding large files in embed-gist-inline - #3890

Merged
fregante merged 4 commits into
masterfrom
embed-gist-limit
Jan 12, 2021
Merged

Avoid embedding large files in embed-gist-inline#3890
fregante merged 4 commits into
masterfrom
embed-gist-limit

Conversation

@fregante

Copy link
Copy Markdown
Member

Fixes #3889

Test on hashicorp/vagrant#11987 (warning, may cause browser to hang before this PR is merged)

Screenshot

Screen Shot 4

This reverts commit 8130491.

For some reason I see the header via HTTPie but not in Chrome…
@fregante fregante added the bug label Jan 12, 2021
@fregante
fregante marked this pull request as ready for review January 12, 2021 01:06

@yakov116 yakov116 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

@fregante

Copy link
Copy Markdown
Member Author

I just noticed that node-fetch has a convenient size limit but the spec doesn't

@fregante fregante changed the title Limit embeddable size in embed-gist-inline Avoid embedding large files in embed-gist-inline Jan 12, 2021
@fregante
fregante merged commit 282bb1e into master Jan 12, 2021
@fregante
fregante deleted the embed-gist-limit branch January 12, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Page freezes after refinded-github Chrome ext runs

2 participants