Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Restore Releases section clean-repo-sidebar but without title - #3918

Merged
fregante merged 3 commits into
refined-github:mainfrom
cheap-glitch:fix-clean-repo-sidebar-error
Jan 31, 2021
Merged

Restore Releases section clean-repo-sidebar but without title#3918
fregante merged 3 commits into
refined-github:mainfrom
cheap-glitch:fix-clean-repo-sidebar-error

Conversation

@cheap-glitch

@cheap-glitch cheap-glitch commented Jan 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for contributing! 馃崉

  1. LINKED ISSUES: Fixes Releases panel is removed (without releases-tab)聽#3848

  2. TEST URLS: Repo with releases disabled in the sidebar

  3. SCREENSHOTS:


Vanilla RGH

Screenshot_2021-01-30 sindresorhus refined-github(1)

Screenshot_2021-01-30 sindresorhus refined-github

This PR also prevents an error in the console, when the "Releases" section in the repo sidebar has been deactivated by the owner.

@fregante

fregante commented Jan 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I'm leaning towards dropping this part of the feature altogether. Re: #3848

Maybe we can just drop the "Releases" header instead, like we do for "Labels" in clean-conversation-sidebar

@yakov116 yakov116 added the bug label Jan 28, 2021
@cheap-glitch

cheap-glitch commented Jan 29, 2021

Copy link
Copy Markdown
Contributor Author

I'm leaning towards dropping this part of the feature altogether. Re: #3848

I don't feel strongly about this either way, but I do find the release link in the sidebar slightly more informative.

Maybe we can just drop the "Releases" header instead, like we do for "Labels" in clean-conversation-sidebar

Then I assume this would be in a separate feature?

@fregante

fregante commented Jan 30, 2021

Copy link
Copy Markdown
Member

Then I assume this would be in a separate feature?

We don't need to fix this if we're removing it in a next PR. This PR should either:

  • delete the sidebarReleases code entirely, or
  • edit this piece of code so that it just hides the "Releases" title

@cheap-glitch

cheap-glitch commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

I've tried hiding the "Releases" title only:


Vanilla RGH

Screenshot_2021-01-30 sindresorhus refined-github(1)

Screenshot_2021-01-30 sindresorhus refined-github

@fregante fregante changed the title Fix error in clean-repo-sidebar Restore "Releases" section clean-repo-sidebar but without title Jan 31, 2021
@fregante

fregante commented Jan 31, 2021

Copy link
Copy Markdown
Member

I hope this is gonna make people in #3848 happy

@fregante fregante changed the title Restore "Releases" section clean-repo-sidebar but without title Restore Releases section clean-repo-sidebar but without title Jan 31, 2021
@fregante
fregante merged commit 77f69e4 into refined-github:main Jan 31, 2021
@cheap-glitch
cheap-glitch deleted the fix-clean-repo-sidebar-error branch January 31, 2021 08:54
@fregante fregante mentioned this pull request Feb 14, 2021
Closed
@fregante fregante mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Releases panel is removed (without releases-tab)

3 participants

@cheap-glitch @fregante @yakov116