Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve clean-repo-sidebar - #5405

Merged
kidonng merged 3 commits into
mainfrom
improve-clean-repo-sidebar
Feb 13, 2022
Merged

kidonng merged 3 commits into
mainfrom
improve-clean-repo-sidebar

Conversation

@kidonng

@kidonng kidonng commented Feb 12, 2022

Copy link
Copy Markdown
Member
  • Move some hiding work to CSS
  • Restore "Releases" header on small screen
  • Hide "Learn more about GitHub Sponsors" link (a "by-product" of selector changes, but shouldn't be controversial)

Test URLs

Screenshot

Before After

@cheap-glitch

Copy link
Copy Markdown
Contributor

Hide "Learn more about GitHub Sponsors" link (a "by-product" of selector changes, but shouldn't be controversial)

+1 if it allows us to drop some JS.

I remember this being rejected before though. That said, back then Sponsors where a new thing so it made sense to keep it.

@kidonng

kidonng commented Feb 12, 2022

Copy link
Copy Markdown
Member Author

I remember this being rejected before though.

Did you mean #3974 (comment)? But the claims sounds invalid to me though:

  • "the link is unique": there's a link to the docs in the sponsor page's footer that seems to be more useful.

    image
  • "it’s not an obvious feature": does the marketing page it links to make things more obvious?

That said, back then Sponsors where a new thing so it made sense to keep it.

It isn't a new thing then either.

@cheap-glitch cheap-glitch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n/a

@kidonng
kidonng merged commit 31027f0 into main Feb 13, 2022
@kidonng
kidonng deleted the improve-clean-repo-sidebar branch February 13, 2022 09:43
@panva

panva commented Feb 15, 2022

Copy link
Copy Markdown

This PR broke some readme rendered markdown, see #5410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants