Adding support for Counting bugs by issue type bug #8430
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
May 4, 2025
| @@ -49,7 +51,7 @@ const bugs = new CachedFunction('bugs', { | |||
|
|
|||
| async function getSearchQueryBugLabel(): Promise<string> { | |||
| const {label} = await bugs.getCached() ?? {}; | |||
| return 'label:' + SearchQuery.escapeValue(label ?? 'bug'); | |||
| return `(label:${label ?? 'bug'} OR type:Bug)`; | |||
| @@ -24,20 +24,22 @@ type Bugs = { | |||
| async function countBugs(): Promise<Bugs> { | |||
| const {repository} = await api.v4(CountBugs); | |||
|
|
|||
| const issuesBugCount = repository.issues.totalCount ?? 0; | |||
|
|
|||
| // Prefer native "bug" label | |||
There was a problem hiding this comment.
Can you simplify this setup? I'd rather see:
const label = repository.labels.find( etc ) ?? 'bug'
const count = repository.labels.find( etc ) ?? 0
return {label, count: count + issuesBugCount}| @@ -24,20 +24,22 @@ type Bugs = { | |||
| async function countBugs(): Promise<Bugs> { | |||
| const {repository} = await api.v4(CountBugs); | |||
|
|
|||
| const issuesBugCount = repository.issues.totalCount ?? 0; | |||
There was a problem hiding this comment.
Suggested change
| const issuesBugCount = repository.issues.totalCount ?? 0; | |
| const bugTypeCount = repository.issues.totalCount ?? 0; |
| @@ -1,4 +1,4 @@ | |||
| const queryPartsRegExp = /(?:[^\s"]|"[^"]*")+/g; | |||
| const queryPartsRegExp = /[^\s"()]+:[^"\s()]*(?:"[^"]*")?|\([^)]*\)|"[^"]*"|[^\s"():]+/g; | |||
There was a problem hiding this comment.
Oof this is a mouthful. Would be good to add more tests with and without parents to see how it behaves
There was a problem hiding this comment.
Yeah, the regex isn't beautiful, I'll add tests for different cases en scenarios!
Of course, I'll take a look at all your suggestions in the coming week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8227
Not the best at crafting regexp, so would appreciate suggestions on how to improve it if possible, but all existing tests on queryPartsRegExp are still passing.
Test URLs
https://github.com/refined-github/refined-github/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen+%28label%3Abug+OR+type%3ABug%29
Unfortunately don't have any public repository available to test the issue type bug on.
Screenshot