Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move recently-pushed branches to the side - #869

Merged
fregante merged 8 commits into
masterfrom
recently-pushed-branches
Dec 23, 2017
Merged

fregante merged 8 commits into
masterfrom
recently-pushed-branches

Conversation

@fregante

@fregante fregante commented Dec 12, 2017

Copy link
Copy Markdown
Member

Closes #851

fade in

Here's how it looks with more than one branch:

3 branches

Not great, considering it hides other content. Possible solutions:

  • x button to close it
  • only show one branch until the user hovers it (if there's more than one it can still show that info)

@fregante fregante changed the title Move branches out of the way Move recently-pushed branches to the side Dec 12, 2017
@fregante

Copy link
Copy Markdown
Member Author

Smaller time, shorter branch-name:

screen shot

@jgierer12

Copy link
Copy Markdown
Contributor

only show one branch until the user hovers it (if there's more than one it can still show that info)

👍

Then we should also reverse the order (move the most recently pushed one to the top)

@hkdobrev

Copy link
Copy Markdown
Contributor

I think handling well just a single branch is good enough :) :shipit:

@fregante
fregante force-pushed the recently-pushed-branches branch from 73eb106 to d28232b Compare December 18, 2017 09:40
@fregante

fregante commented Dec 18, 2017

Copy link
Copy Markdown
Member Author

Regular

Bottom border highlights that there's more

Hover

Updated readme gif

r

@fregante fregante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing new feature

@fregante
fregante merged commit 3d37c8b into master Dec 23, 2017
@sindresorhus
sindresorhus deleted the recently-pushed-branches branch December 23, 2017 09:31
@borekb

borekb commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

One thing I found out: disabling the feature by adding show-recently-pushed-branches to Options only disables showing the notifications on all pages; it still shows the floating panel on repo homepage. Which is a state I actually like very much :)

The better description of this feature would be that it moves the notifications to floating panels and adds those panels to other pages like issues and PRs.

@fregante

fregante commented Jul 20, 2018

Copy link
Copy Markdown
Member Author

show-recently-pushed-branches actually only adds that banner to some pages (I think isIssueList) instead of just appearing on the repo root. Feel free to add a /* */ header on that file as documentation :D

The feature of this PR is CSS-based and can't be disabled.

@borekb

borekb commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

Thanks, understood, disabling the "feature" but keeping the styles is actually a perfect fit for me.


As a complete side note, I was thinking that maybe it would be nice if features were implemented by adding some CSS classes to DOM via feature's javascript, and then CSS in content.css was targeting them, not the default ones. That would make feature disabling clean and complete.

At the same time, I'm super-happy that feature disablability is in Refined GitHub in the first place. Last time I tried to use it (sometime last year I think) there were too many decisions that actually made the experience worse for me. The new system is both simple and goes a very long way towards customizability, so I'm happy overall.

@fregante

Copy link
Copy Markdown
Member Author

Refer to #988 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Avoid jump caused by recently pushed branches

5 participants