release-download-count - Fix overlap
#8742
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Add at the beginning of the line to avoid (clickable) content shift | ||
| assetSize.parentElement!.prepend( | ||
| <span className={className}> | ||
| <span className={[...getClasses(assetSize)].join(' ')}> |
Contributor
There was a problem hiding this comment.
just curious: why did you choose this over assetSize.className?
Member
Author
There was a problem hiding this comment.
getClasses also strips out any Refined GitHub classes
Contributor
There was a problem hiding this comment.
Oh, I thought this was a standard JS function. I googled it but didn't read past the word "Java", lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release-download-countgets mixed with asset name when the page narrows #8323Test URLs
https://github.com/NateShoffner/Disable-Nvidia-Telemetry/releases
Screenshot
Screenshotted paired with #8735