extensible-nav - New feature - #9554
Conversation
| }, | ||
| { | ||
| "id": "extensible-nav", | ||
| "description": "This is a core feature that enables other Refined GitHub features to extend or modify the repository navigation bar.", |
There was a problem hiding this comment.
The name is intentionally generic because this will eventually also apply to user/org profiles
fregante
left a comment
There was a problem hiding this comment.
Let's merge this and test it out for a while before the next release.
| /* TODO: Remove before shipping. Temporary indicator of successful replacement */ | ||
| border-left: 1px solid var(--borderColor-muted, fuchsia); |
There was a problem hiding this comment.
I'm going to leave this small border in until just before release. The navs are so similar it's hard to tell if extensible-nav is working at all unless the More dropdown appears.
|
With this new feature enabled, a userstyle (Github Compact style) I've been using for ages becomes (mostly) broken 😞 ... Before PR 9554/with new feature disabled: 
(this is the intended look of the userstyle) After PR 9554 + new feature enabled (the default setting): 
Pardon me for asking, but is this something that should be addressed by the userstyle author? Thanks. Later addition:
Actually, I'm now seeing a very weird behaviour that I can't, for the life of me, make heads or tails of it; I re-enabled the above new feature and on most repos (and their sub-pages), the userstyle works as intended, e.g. on https://github.com/snawoot-proxies-forks/opera-proxy But on select repos or select repo sub-pages, the userstyle becomes broken: https://github.com/refined-github/refined-github What is this? Some kind of race-condition, or what? ... |
|
Thanks for the report. Yes at this point there's no compatibility layer with other user styles. We could add some classes so that they match, but since anyone can pick any selector it's unlikely we'll match every selector of every userstyle. As for the second part, if the userstyle works, most likely the |
|
Yep, it's because I did not set up the Discussions and Projects icon. It's failing as expected 
|
releases-tab,bugs-tab,clean-repo-tabsbroken #8867GitHub still ships the old
UnderlineNavstyle, but here it is just in case they delete it in the future: https://gist.github.com/fregante/a718156c4187e42879a2033222394868 (the gist also includes the static HTML)Current status
The .UnderlineNav class natively overflows, but we could already immediately consider wrapping the items on multiple lines instead.
Current page is preserved:
Tasks