Add ability to remove hotfixes temporarily - #9875
Merged
Merged
Conversation
fregante
commented
Jul 22, 2026
| </button> | ||
| <button type="button" onclick={emptyHotfixes}> | ||
| Empty hotfixes | ||
| </button> |
Member
Author
There was a problem hiding this comment.
I just don't know how yet:
- document what this does: it lasts a few hours
fregante
marked this pull request as ready for review
August 5, 2026 10:05
fregante
enabled auto-merge (squash)
August 6, 2026 09:02
fregante
disabled auto-merge
August 6, 2026 09:02
This reverts commit ff455b0.
fregante
commented
Aug 7, 2026
| if (isDevelopmentVersion()) { | ||
| return []; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Condition moved in here, much easier to manage
| // To facilitate debugging, ignore hotfixes during development. | ||
| // Change the version in manifest.json to test hotfixes | ||
| updater: async (version: string): Promise<string> => | ||
| isDevelopmentVersion() ? '' : fetchHotfix(`style/${version}.css`), |
Member
Author
There was a problem hiding this comment.
Bugfix: 0.0.0.css was fetched unnecessarily
|
|
||
| export async function applyStyleHotfixes(style: string): Promise<void> { | ||
| if (!style || isDevelopmentVersion() || isEnterprise()) { | ||
| if (!style || isEnterprise()) { |
Member
Author
There was a problem hiding this comment.
style is empty on the dev version
|
|
||
| if (details.open) { | ||
| querySelector('input, textarea', details)?.focus({preventScroll: true}); | ||
| querySelector('input:read-write, textarea:read-write', details)?.focus({ |
Member
Author
There was a problem hiding this comment.
This would select the hotfixes textareas, but it's not editable so that's not useful
| await elementReady('.js-features', { | ||
| stopOnDomReady: false, | ||
| signal: AbortSignal.timeout(500), | ||
| signal: AbortSignal.timeout(1000), |
Member
Author
There was a problem hiding this comment.
Slow internet triggered the error banner and broke the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful to see if a bugfix was released or if it's just a hotfix