feat(node-sdk): allow passing meta to getFeature(s)
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced JSDoc comments for BucketClient methods - Added more detailed parameter descriptions - Improved type checking for meta context - Extracted meta validation into a separate function - Updated type definitions for context and tracking options - Refined error messages for validation
roncohen
reviewed
Feb 9, 2025
roncohen
reviewed
Feb 9, 2025
roncohen
reviewed
Feb 9, 2025
roncohen
approved these changes
Feb 9, 2025
- Reverted package version from 1.5.3 to 1.5.2 - Enhanced JSDoc comments for BucketClient constructor - Added documentation for `secretKey` parameter - Marked BoundBucketClient constructor as internal
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
This PR adds the ability to pass the `meta` to `getFeature(s)` and the bound client.
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
This PR adds the ability to pass the `meta` to `getFeature(s)` and the bound client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass the
metatogetFeature(s)and the bound client.