Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feedback Source #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2023
Merged

Feedback Source #78

merged 4 commits into from
Nov 17, 2023

Conversation

rrpff
Copy link
Contributor

@rrpff rrpff commented Nov 14, 2023

No description provided.

@rrpff rrpff force-pushed the buc-1603-source-says-api-in-the-feedback-tab branch from ca419e6 to 54c9e64 Compare November 15, 2023 17:24
@rrpff rrpff requested review from Swiftwork and pavkam November 15, 2023 17:24
Swiftwork
Swiftwork approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Swiftwork Swiftwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity and education, can you write a brief comment description for when we can expect each source?

"api" | "manual" | "prompt" | "sdk" | "widget"

@roncohen roncohen mentioned this pull request Nov 17, 2023
Merged
@rrpff rrpff force-pushed the buc-1603-source-says-api-in-the-feedback-tab branch from 5d4982f to 690c0e6 Compare November 17, 2023 12:07
pavkam
pavkam reviewed Nov 17, 2023
View reviewed changes
@rrpff rrpff force-pushed the buc-1603-source-says-api-in-the-feedback-tab branch from 690c0e6 to 76d41bf Compare November 17, 2023 15:10
@rrpff
Copy link
Contributor Author

rrpff commented Nov 17, 2023

@Swiftwork good shout - added some extra info to the comment. I don't expect this property to be used by customers, but didn't want to introduce extra misdirection to avoid it being visible.

@rrpff rrpff merged commit 852c675 into main Nov 17, 2023
@rrpff rrpff deleted the buc-1603-source-says-api-in-the-feedback-tab branch November 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavkam pavkam pavkam left review comments

@Swiftwork Swiftwork Swiftwork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrpff @Swiftwork @pavkam