Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

roncohen
Copy link
Contributor

@roncohen roncohen commented Nov 16, 2023

init options now take a separate sseHost to let users select a different host for the live connection. This is in addition the existing host option. Both of these are useful for proxying.

@roncohen roncohen requested review from rrpff and pavkam November 16, 2023 14:11
Copy link
Contributor

@pavkam pavkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pavkam pavkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing to note that sseHost is used for both SSE and REST calls, but I don't think people can selectively disable REST if proxying as they both do GET requests.

@roncohen
Copy link
Contributor Author

Thanks!

@roncohen roncohen merged commit fb9e335 into main Nov 16, 2023
@roncohen roncohen deleted the allow-custon-sse-host branch November 16, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants