Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rrpff
Copy link
Contributor

@rrpff rrpff commented Dec 6, 2023

No description provided.

@rrpff rrpff requested review from Munter and Swiftwork December 6, 2023 17:54
@rrpff rrpff force-pushed the buc-1415-add-inline-typescriptjsdoc-documentation-to-sdk-methodstypes branch from 90bc20c to 2d9e561 Compare December 6, 2023 19:16
@rrpff
Copy link
Contributor Author

rrpff commented Dec 6, 2023

@pavkam I didn't describe each option when there are object args, as there are already JSDoc descriptions on the properties themselves. I originally started down that road, but felt the likelihood of the duplication drifting was too high.

Personally when using IDE hints, I only read the function description for general usage, and then each option for more specificity, so went with that approach.

i.e. function:
image

property:
image

Thoughts?

@pavkam
Copy link
Contributor

pavkam commented Dec 7, 2023

@pavkam I didn't describe each option when there are object args, as there are already JSDoc descriptions on the properties themselves. I originally started down that road, but felt the likelihood of the duplication drifting was too high.

Personally when using IDE hints, I only read the function description for general usage, and then each option for more specificity, so went with that approach.

i.e. function: image

property: image

Thoughts?

I know some people prefer pure JSDoc to TS. I am by no means an expert in how these things work to be honest. I'll defer to your judgement.

@rrpff rrpff force-pushed the buc-1415-add-inline-typescriptjsdoc-documentation-to-sdk-methodstypes branch from b3cb02d to 70c2695 Compare December 8, 2023 11:58
@rrpff
Copy link
Contributor Author

rrpff commented Dec 8, 2023

Not an expert either, noted prisma/react/chakra/react-router just have a short description then link to docs. Will merge this for now as it's an improvement

@rrpff rrpff merged commit 25efeac into main Dec 8, 2023
@rrpff rrpff deleted the buc-1415-add-inline-typescriptjsdoc-documentation-to-sdk-methodstypes branch December 8, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants