Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cache Ably auth-cookie #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 15, 2023
Merged

Cache Ably auth-cookie #88

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
74d2514
feat: remember the auth token
pavkam Dec 12, 2023
aa54fa7
feat: secure the cookies
pavkam Dec 12, 2023
112ca5a
whoops: forgot to update the tests
pavkam Dec 12, 2023
8f0037e
feat: avoid `init` call if we have a cached token
pavkam Dec 12, 2023
abd662c
chore: linter
pavkam Dec 12, 2023
b64b83a
whoops: mistakenly made a typo
pavkam Dec 12, 2023
73fae39
whoops: fix broken tests
pavkam Dec 12, 2023
348216d
feat: fix e2e by supplying an empty page
pavkam Dec 12, 2023
4af7224
whoops: forgot the test code
pavkam Dec 12, 2023
e67cca4
chore: PR comments
pavkam Dec 15, 2023
464ec8f
chore: add explicit check
pavkam Dec 15, 2023
a678c63
Update test/usage.test.ts
pavkam Dec 15, 2023
4d4d669
chore: fix test
pavkam Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add explicit check
  • Loading branch information
@pavkam
pavkam committed Dec 15, 2023
commit 464ec8ffb9e3abbebc5c8ba6d0c7974536ac5629
12 changes: 11 additions & 1 deletion test/usage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,11 +303,18 @@ describe("feedback prompting", () => {
expect(closeAblySSEChannel).toBeCalledWith("fake_client");
});

test("does not call tracking endpoint if token cached", async () => {
test("does not call tracking endpoints if token cached", async () => {
vi.mocked(getAuthToken).mockReturnValue({
channel: "super-channel",
token: "something",
});

const n = nock(`${TRACKING_HOST}/${KEY}`)
.post(/.*\/feedback\/prompting-init/, {
userId: "foo",
})
.reply(200, { success: true, channel: "test-channel" });

const bucketInstance = bucket();
bucketInstance.init(KEY, {
persistUser: false,
Expand All @@ -323,6 +330,9 @@ describe("feedback prompting", () => {
expect.anything(),
expect.anything(),
);

expect(n.isDone()).toBe(false);
n.done;
});

test("does not initiate feedback prompting if server does not agree", async () => {
Expand Down