Flow Separation Warning #205
Conversation
reilleya
left a comment
There was a problem hiding this comment.
Great idea! Two small things to tweak.
f601f03 to
1ed6114
Compare
|
Both changes have been implemented. I also added some import logic so older files will have the correct default separation ratio. I also added a fix where the start and end data points would trigger the warning, so the warning now only triggers if the condition persists. |
1ed6114 to
a0c3344
Compare
|
The test build of this patch fail. Perhaps something to look at? |
reilleya
left a comment
There was a problem hiding this comment.
Sorry for the delay. One more tweak. Also, I fixed the issue with the tests on staging so you can rebase and this should pass.
452c1d7 to
c9d70b2
Compare
|
All new requested changes have been implemented. |
d2691ef to
c9d70b2
Compare
|
I finally got around to playing with this and really like it! Last issue is that the warning text is too long, at least on my laptop: |
|
Hi Andrew,
Is the latest available from “Stage”. I’d like to give it a try.
Ben
From: Andrew Reilley ***@***.***>
Sent: Thursday, May 18, 2023 11:33 PM
To: reilleya/openMotor ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [reilleya/openMotor] Flow Separation Warning (PR #205)
I finally got around to playing with this and really like it! Last issue is that the warning text is too long, at least on my laptop:
<https://user-images.githubusercontent.com/9787344/238164845-83af2ed5-2fc3-49ca-baec-d98acaaa1592.png>
I know what it says so it isn't a problem for me, but it seems like we should either find a more concise message, make this window resizable, or at least make it wider. I'd be happy to merge it with that changed!
—
Reply to this email directly, view it on GitHub <#205 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL4HO6G5YZA25EX2X7SD2OTXG3SYTANCNFSM6AAAAAATULZMFM> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AL4HO6FU4O3VSNXVCCR4WETXG3SYTA5CNFSM6AAAAAATULZMFOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS4T5R2E.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Not quite! It will be once this is merged, which will happen as soon as we touch up the text in the warning. |
If the simulation shows an exit pressure which is below the Summerfield Criteria for flow separation, a warning will be generated. Implementing Requested Changes Nozzle Flow Separation Warning now triggers on a % threshold rather than on any value. Threshold is adjustable. Updated Warning message warning message now shorter to fit smaller screens.
628d827 to
121aa04
Compare
|
I've made the requested change, the warning text is now approximately the same length as the other warnings. A longer term future improvement seems to be warranted to improve the warning message GUI to support more verbose and informative messages, but I'm going to put a pin in that for now. |
|
Thanks Andrew. Will give it a try.
Ben
From: Andrew Reilley ***@***.***>
Sent: Monday, May 29, 2023 9:41 PM
To: reilleya/openMotor ***@***.***>
Cc: benrussell11 ***@***.***>; Comment ***@***.***>
Subject: Re: [reilleya/openMotor] Flow Separation Warning (PR #205)
Merged #205 <#205> into staging.
—
Reply to this email directly, view it on GitHub <#205 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL4HO6DPOHKBDVL4E3NX5U3XIVF3ZANCNFSM6AAAAAATULZMFM> .
You are receiving this because you commented. <https://github.com/notifications/beacon/AL4HO6G2THJIL5NRDKC5Q5TXIVF3ZA5CNFSM6AAAAAATULZMFOWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAELVKGFIA.gif> Message ID: ***@***.*** ***@***.***> >
|
If the simulation shows an exit pressure which is below the Summerfield Criteria for flow separation, a warning will be generated.