forked from googleads/google-ads-python
-
Notifications
You must be signed in to change notification settings - Fork 0
Changes for release v14_1. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reilly-codes
wants to merge
48
commits into
reilly-codes:main
Choose a base branch
from
googleads:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an includecode section in get_campaigns.py so it can be used in the "Getting Started" guide.
To align with the [code example change](googleads/google-ads-java#742) requested for the Java client library. As seen in this [blog announcement](https://ads-developers.googleblog.com/2023/09/google-ads-shopping-campaign-enhanced.html), any Shopping campaigns using Enhanced cost-per-click (eCPC) will behave as if they are using Manual cost-per-click (CPC) bidding. Because of the change, I'm updating the examples related to the announcement to reflect the new recommended practice.
Should be using country_code and postal_code (see ref: https://developers.google.com/google-ads/api/reference/rpc/v15/OfflineUserAddressInfo). Sorry I missed this on my last PR.
…d points have been fixed.
Change-Id: Ide8079c878fb3f5a5d5d7220e0e00a35d987d4f3
* Add ability to run unit tests in a Docker container * Remove support for Python 3.7 * Add support for Python 3.12 * Remove support for Google Ads API v13 * Move to implicit namespace, remove usage of pkg_resources
Add new recommendation devsite tags
Migrate setup.py file to a pyproject.toml file Add support for Python 3.13 and remove support for 3.8 Fix bug in upload_offline_conversion example. Update library to support default gapic templates. Regen v17, v18, and v19 with default templates. Remove v16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test