fix: report the CLI version in the client header - #148
Merged
Conversation
The CLI sent a bare "cli", so a bug report could say the traffic came from the CLI but never which build. That matters more here than anywhere else: the CLI self-updates, so the installed version is exactly the thing nobody can tell you after the fact. VERSION is already generated from package.json at build time and used in four other places, so this cannot drift.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of an audit of client identification across every Rendobar client.
The gap
The CLI sent a bare
cli. A bug report could say traffic came from the CLI butnever which build — and that matters more here than anywhere else, because
the CLI self-updates, so the installed version is exactly the thing nobody
can tell you after the fact.
Every client now agrees
sdk/5.10.0activepieces/0.2.0mcp/1.11.0sdkn8n/0.5.0cli/1.12.2No drift risk
VERSIONis already generated frompackage.jsonat build time and used infour other places, so there is no new constant to keep in sync.
Checks