fix: treat storage:// and asset:// inputs as remote, not local files - #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rb ffmpeg -i storage://demo-bucket/raw/clip.mp4 ...failed withFile not found: storage://demo-bucket/raw/clip.mp4, becauseisLocalPathonly countedhttp://andhttps://as remote. Anything else was treated as a path on disk and uploaded.storage://(a file in a connected bucket) andasset://(an uploaded asset) are resolved by the API, so the CLI now passes them through unchanged.rb ffprobeandrb edit --imagesuse the same check and get the same fix.Merge after the API storage feature (rendobar/rendobar#682) is deployed to production. Until then the API does not accept these URIs in a command.
Test plan
storage://andasset://inputs areisLocal: falsepnpm test(231 pass),pnpm typecheck