Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Conversation

@laverya
Copy link
Member

@laverya laverya commented Aug 27, 2019

What I Did

Moved ship from dep to go modules

How I Did it

go mod init + some manual fixup for imports it didn't like (github.com/google/go-github -> github.com/google/go-github/v18, gopkg.in/ksplit.v0 -> github.com/go-ksplit/ksplit)

How to verify it

CI still passes, etc

Description for the Changelog

Ship now uses go modules.

Picture of a Ship (not required but encouraged)

USS T-1 (SS-52)

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 422107 lines exceeds the maximum allowed for the inline comments feature.

@laverya laverya requested a review from areed August 27, 2019 00:39
@laverya laverya merged commit abf7e61 into replicatedhq:master Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants