This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Improve cert template function expiry behavior #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Certificates now have a default expiry of two years, instead of one. If an existing cert or a CA will expire within 6 months of Ship being run, the cert will be regenerated or the CA will be renewed.
How I Did it
Changed the certificate request code to include a duration other than the default of 1 year.
Changed the certificate/CA read code to check expiration dates and regenerate things as required.
How to verify it
New unit tests
Description for the Changelog
Generated certificates now have a validity period of two years
If a generated certificate will expire within 6 months of ship being run, it will be regenerated to extend the validity period
Picture of a Ship (not required but encouraged)