change the tryPort to use hostname.local (for wsl to work)#582
Open
thatgurkangurk wants to merge 4 commits into
Open
change the tryPort to use hostname.local (for wsl to work)#582thatgurkangurk wants to merge 4 commits into
thatgurkangurk wants to merge 4 commits into
Conversation
fedeericodl
requested changes
Oct 24, 2023
12944qwerty
requested changes
Oct 24, 2023
12944qwerty
left a comment
Member
There was a problem hiding this comment.
This unfortunately isn't supported on Mac devices. You may need to add a check to see if it's mac or not to choose to use .local or localhost.
Contributor
{
find: "RPCServer:WSS",
replacements: [
{
match: "127.0.0.1",
replace: () => `0.0.0.0`,
},
],
}Include this patch in replugged with a toggle for this. Also if possible make it an argument or env variable.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when you try to use the --watch flag in wsl, it cannot connect since the networks are technically separated. if you use hostname.local however, the wsl "container" can connect to the main windows machine.
this should not break any other systems since i tested it in linux, linux in wsl and on windows without issue