This repository was archived by the owner on Aug 2, 2023. It is now read-only.
feat: enable pipe failure propagation through Bash #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the now open sourced
github/docs, we have run into at least one situation where this Action arguably should've failed but did not. The situation was due to a misconfiguration on our part after we renamed our default branch frommastertomainbut hadn't yet updated the branch name used in our Actions workflows.Example failure: https://github.com/github/docs/runs/1123997453?check_suite_focus=true
This particular failure arose from the current line 36 in the
entrypoint.shscript:pull-request/entrypoint.sh
Lines 35 to 40 in 73a5d56
Having
set -eenabled as you do is a great practice but there are often other options to consider adding, especially-o pipefail. Without it, failing exit codes from command that are piped into other commands do not cause the script to exit. πFrom the Bash manual:
cc @chiedo