This repository was archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 127
Major improvements and resolutions to most open issues. #59
Closed
arizonaherbaltea
wants to merge
5
commits into
repo-sync:master
from
arizonaherbaltea:feature/improve_arg-expansion_console-prints_print-verbosity_pr-alt-repo_dupe-pr-handling
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en passed to the 'hub' cli so that double and single quotes are appropriately handled, github action grouping of console prints for easier troubleshooting and status indication, more console prints with better details regarding internal state, bash set -x debugging parameter, generalize the "GITHUB_TOKEN" so Personal Action Tokens may be used as well, add support for 3rd party or repositories that are currently checked out, improved 'hub' cli error handling so that the action stops and errors when the pull-request fails to create, duplicate pull request handling where the head and base or destination and source branches are the same and in this case the action continues and finds the PR url and PR number.
Member
|
👋 @herbaltealeaf Thanks so much for your contribution. We will review it and publish a new major release version once approved. |
wei
reviewed
Mar 2, 2021
wei
reviewed
Mar 2, 2021
|
this looks nice. any chance we can get this merged soon? |
|
Yeah pretty excited about these changes, would love to roll them out to our productive systems. Any chance of an ETA? |
Member
Member
|
Hi there thank you for the amazing PR, I have incorporated a number of the changes in #117 @allcontributors add @arizonaherbaltea for code |
Contributor
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @arizonaherbaltea! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Since this introduces so many changes a more robust test of the other parameters may need to be conducted.
Example 1
Here is an example that shows double quotes in the PR body are handled properly.
Example 2
This is what happens when a pull-request is created, but one with the same base and head branches already exists.

Example 3
How to open a pull-request to a repo which is different from the one currently checked out.
Note the use of a Github Personal Action Token during code checkout.. Even though the pull-request is being performed on another repo, a PAT with rights to the other repo is needed to successfully create the pr. The default GITHUB_TOKEN that the checkout action uses is insufficient!
Note
These changes are as is. I've improved upon this pull-request action for use with my org and am sharing the results of that labor here. Merge it, don't merge it, agree, don't agree, edit the pr, fork the fork, whatever. Its all good. I don't really care.
However if you are seeing bugs, let me know so it can be fixed.