-
Notifications
You must be signed in to change notification settings - Fork 127
Add third-party repository support #69
Conversation
chore: fetch upstream
# Conflicts: # entrypoint.sh
|
Hey I've just come across this today, it seems to be exactly what I need 🎉 is there any chance of getting it merged? |
|
@mansona You can use my PR branch for the moment. I use this on pretty much all of my projects. - name: pull-request
uses: m4heshd/pull-request@third-party-repos
with:
destination_branch: "main"
github_token: ${{ secrets.GITHUB_TOKEN }}Or you can simply fork it and use. |
|
Thanks for the bump. Will review and try to merge it soon. |
|
@m4heshd yes I have been doing that to test this out 👍 one thing I will say as possible feedback, I had accidentally put the wrong name for the token for this action and it failed to create the PR, but it still showed as succeeding 🤔 https://github.com/mansona/test-copy-file-source/runs/5235589544?check_suite_focus=true#step:6:25 I don't know exactly how to do this but you might want to make sure that the exit code is correct in this scenario since I suspect that will be the most common error people will have (i.e. not having the right credentials set up) |
|
@mansona Hmm.. 🤔. Gonna have to take a look at that. I already see what the issue is but need some free time on my hands to do some tests. |
|
@m4heshd do you want to share the issue and maybe I can take a look? i.e. if you know what the problem is then maybe write a brief description here and if i have time I can take a look 👍 |
|
I'm trying to use the action in a private repo to no avail: Given the following config: we're getting an error: |
# Conflicts: # entrypoint.sh
|
@mansona Sorry I missed your last response. I'm gonna take a look at it again. @steven-prybylynskyi It's because of #84. Not related to this PR. But it should be fixed now since the changes are merged. Meanwhile, can y'all try my fork ( |
|
@ReenigneArcher I saw your issue in my mail and now you've deleted it. Can you confirm if everything's working correctly? |
Sorry, my original issue was a dumb mistake on my part. I was accidentally using I do have one issue here though. - name: Create Pull Request
# uses: repo-sync/pull-request@v2
# use this branch temporary to support creating PR against another repo
uses: m4heshd/pull-request@third-party-repos
with:
destination_repository: ${{ github.repository_owner }}/somerepo
source_branch: ${{ env.update_branch }}
destination_branch: nightly
pr_title: "Update"
pr_body: "Update with changes from ${{ github.repository }}"
pr_assignee: ${{ secrets.GH_BOT_NAME }}
pr_draft: false
pr_label: "dependencies, submodules"
pr_allow_empty: false
github_token: ${{ secrets.GH_BOT_TOKEN }}PR labels are not being added to the PR that's created. Here is the created PR: LizardByte/Sunshine#603 Note that the two labels I removed are added by another workflow... the two I specified here are not added at all. |
|
@ReenigneArcher You can't have spaces between the labels list. |
|
@wei Can we get this very useful PR merged? It's quite difficult to keep a 16-month-old PR up to date while resolving merge conflicts. |
wei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @m4heshd for helping. Merry Christmas!🎄 🎁 🎇 🥂
|
@allcontributors add @m4heshd for code |
|
I've put up a pull request to add @m4heshd! 🎉 |
|
@wei Thank you for merging and Merry Christmas to you as well fellow dev. 🎄🎅🏽 |
|
It's now available at |
This PR adds following features:
destination_repository)Sample usage:
In this example, the PR will be created in
octocat/hello-world.Notes:
🔵 Manual input has the highest priority. Final fallback is
GITHUB_REPOSITORYenv var🔵 Supports both bare and non-bare repositories
🔵 Does not depend on
actions/checkout🟢 Minimal amount of modifications to the original source
🟢 Changes are fully backwards compatible
🟢 Functionality has been tested in numerous possible scenarios
Related issues: #18, #55