Adding a config option to stop assuming module filenames end in .js #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disableAutoJsExt: true, is set you have to pass complete file names including extension when requiring modules such as foo.js or foo.njs instead of foo I am using require.js server side with node.js and I need to name my modules .njs or .model etc to separate them from static .js files. The noext plugin does not work serverside with node.js and I feel assuming a file ext is unwise in general. If I missed an obvious way to accomplish this, please let me know. Someone more familiar with r.js code then me should review and modify this patch as needed. Making sure it doesn't break anything (like undef etc). However it is done I think allowing non .js file extensions for module files is important.
|
Why not use |
|
Why not use foo.n.js? To use foo.n.js I would need a regex that matched foo.js but not foo.n.js (and my other 4 non static .suffixes) This would make the regex complex enough that I don't know how to write it. Considering that javascript doesn't do negative look-behind and I can't reverse the string and use negative look-ahead since I am passing the regex to code I didn't write. The regex is simple when I use .njs for non static js files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config option to stop assuming module filenames end in .js
When disableAutoJsExt: true, is set you have to pass complete file
names including extension when requiring modules such as foo.js or
foo.njs instead of foo
I am using require.js server side with node.js and I need to name my
modules .njs or .model etc to separate them from static .js files.
The noext plugin does not work serverside with node.js and I feel
assuming a file ext is unwise in general. If I missed an obvious way
to accomplish this, please let me know. Someone more familiar with
requirejs code then me should review and modify this patch as needed.
Making sure it doesn't break anything (like undef etc).
However it is done I think allowing non .js file extensions for
module files is important.