Remove untagged Component::descriptor()
#10038
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
6273747 to
ef67f98
Compare
|
Do you think we should come up with a different name / type? |
|
I'm nervous about "untagged" because of the rerun-historical connotation: There was a world where we had only component name so this was truly untagged. But since 0.22 everything always has a tag, just that that tag is sometimes component-name-only. Calling component-name-only "untagged" rubs me a little bit the wrong way because compared to 0.21 it's still technically tagged. But a) that's ancient past now and b) I don't have any better idea what to call this either and it's good to give it a name! |
|
We have decided on calling these type of descriptors partial instead of untagged. |
Related
What
Another big step towards having full tagging support in the viewer. By removing
Component::descriptor()we make it harder to accidentally use untagged descriptors and therefore reduce bugs in our code, and in our users code.This refactor goes right up to the point where we have to change our SDKs, so there is more design work to be made (via new
AnyValues).To achieve this we still rely on untagged components when implementing
ComponentBatch::descriptor(left todos there).Next steps are:
Component::name())AnyValuesAnyValuesshould use argument names to setarchetype_field_namemetadata #9906 for all SDKs.ComponentDescriptor::newmore explicit when using untagged components or prevent untagged components all together by removing the optionals.ComponentBatch(Maybe we wait for the removal of indicator components).Dependency