Introduce ConnectionRegistry for centralised redap client and token management
#10078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
ConnectionRegistry for centralised redap client and token management
148da13 to
1f28051
Compare
abey79
commented
May 27, 2025
abey79
commented
May 27, 2025
abey79
commented
May 27, 2025
crates/viewer/re_viewer/src/app.rs
Outdated
| app_env: &crate::AppEnvironment, | ||
| startup_options: StartupOptions, | ||
| creation_context: &eframe::CreationContext<'_>, | ||
| connection_registry: Option<ConnectionRegistry>, |
There was a problem hiding this comment.
Can we make do without that as argument, and a App::add_token(origin, token) instead?
There was a problem hiding this comment.
This is annoying because of how entrypoints.rs and streaming works. We start streaming data before creating App, this this requires a connection registry (seeded with --token). If App would create it's own registry, the following sequence would apply:
- create a temp registry with
--tokenif any - kick off stream with temp registry
- create
App - set the
--tokenagain onApp's registry
with the added downside that App's registry doesnt inherit from the connection established by stream (not that it's a huge deal).
Also, see:
abey79
commented
May 27, 2025
abey79
commented
May 27, 2025
abey79
commented
May 27, 2025
Wumpf
approved these changes
May 28, 2025
abey79
added a commit
that referenced
this pull request
May 28, 2025
) ### Related - closes https://github.com/rerun-io/dataplatform/issues/726 - closes https://github.com/rerun-io/dataplatform/issues/721 - part of https://github.com/rerun-io/dataplatform/issues/750 - part of https://github.com/rerun-io/dataplatform/issues/763 - follow-up to #10078 - DNM: chained ### What This PR introduce the concept of "fallback token", which is essentially the same as the `REDAP_TOKEN` env var for the purpose of the web viewer. It is now automatically set from the enclosing notebook environment, if that environment has `REDAP_TOKEN` set. Thanks @jprochazk for the help 🙏🏻
abey79
added a commit
that referenced
this pull request
May 29, 2025
### Related - Follow up to #10078 ### What One should not hold to a `RedapClient` for extended periods of time, as they might need to be periodically refreshed in the future (for auth purposes). This PR changes the SDK implementation such that it always gets a fresh copy of the client instead of holding on to the same one forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
--tokenoption to the rerun CLI #10068What
This PR introduces a new
ConnectionRegistrystructure to hold on open redap connections and known tokens.userdev-facing change is thatRedapClientare now locally sourced from your friendly neighbourhoodConnectionRegistry.re_grpc_client::redap::clientis no longerpub.App. In the future, the entrypoint may pre-populate it with token passed from the CLI.CatalogClientnow has an optionaltokenargument.REDAP_TOKENenv variable is still used, but is overridden by any user provided token.Todo
dataplatfomwill need a quickusefix after landing this