Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jzubizarreta
Copy link
Contributor

Small improvement to make sure the arrow code is downloaded inside the rerun build folder. This avoids polluting custom project build folders when using CMake and FetchContent

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@jzubizarreta
Copy link
Contributor Author

It seems like I cannot add any labels to the issue :(

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah neat that makes sense! Thank you!

@Wumpf Wumpf added sdk-cpp C/C++ API specific include in changelog labels Jun 4, 2025
@Wumpf Wumpf changed the title CMake improvement to download arrow inside the rerun build folder (CMake) download arrow inside the rerun build folder instead of general binary folder Jun 4, 2025
@Wumpf Wumpf merged commit 2ea6dd8 into rerun-io:main Jun 4, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants