Rename to tee to set_sinks
#10312
Rename to tee to set_sinks
#10312
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| recording: RecordingStream | None = None, | ||
| ) -> None: | ||
| """ | ||
| Stream data to multiple different sinks. |
There was a problem hiding this comment.
here and on recording_stream:
what happens to any data logged so far, will those new sinks catch up (I reckon no).
I think this is important to clarify.
the interaction of spawn=True and attach_sinks is also worth pointing out on rr.init's documentation
There was a problem hiding this comment.
words are hard. it still seems a bit complicated but i've probably spent enough time trying to reword it, so i'll leave it as is in the latest commit and merge. the fact that it's not "easily" documentable suggests to me that what we have is overly complex, and we should head towards "first class sinks" as the only thing asap.
Changing the name discussed in #10158 (comment)
We also decided to add back the stateful API.