Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add set_sinks to C++ RecordingStream #10359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 25, 2025
Merged

Add set_sinks to C++ RecordingStream #10359

merged 18 commits into from
Jun 25, 2025

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jun 25, 2025 •
edited
Loading

Adds set_sinks to the C++ API:

rerun::RecordingStream stream("test");
stream.set_sinks(rerun::GrpcSink{}, rerun::FileSink{"data.rrd"});

@jprochazk jprochazk added this to the 0.24.0 milestone Jun 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 70c4033 https://rerun.io/viewer/pr/10359 +nightly +main

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk marked this pull request as draft June 25, 2025 11:28
@jprochazk jprochazk marked this pull request as ready for review June 25, 2025 13:35
@Wumpf Wumpf self-requested a review June 25, 2025 13:44
Wumpf
Wumpf approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always impressive how much more wrangling goes into C++. Looking great though, nice work!

@jprochazk jprochazk merged commit bb2e3ee into main Jun 25, 2025
46 of 47 checks passed
@jprochazk jprochazk deleted the jan/set-sinks-cpp branch June 25, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog sdk-cpp C/C++ API specific
Projects
None yet
Milestone
0.24.0 - Streaming video, no more ind...
Development

Successfully merging this pull request may close these issues.
2 participants
@jprochazk @Wumpf