-
Notifications
You must be signed in to change notification settings - Fork 539
Deprecate serve_web
and improve documentation around how to serve a web viewer
#10360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
since = "0.20.0", | ||
note = "use rec.serve_grpc() with rerun::serve_web_viewer() instead" | ||
)] | ||
pub fn serve( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this since it was overdue and in turn now relied on a deprecated method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful ❤️
e49b906
to
0851c10
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/15878107461 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/15879256526 |
Related
serve_web
#9541What
We were lacking a lot of documentation in that area. Addressing this here alongside deprecation of
serve_web
.serve_web
is still available, but it's recommended to use an explicit combination ofserve_grpc
andserve_web_viewer
now. The rationale is thatrr.serve_web
was confusing as it created two different serves that can get easily confused.Python:
Rust:
(these snippets are part of the documentation as well now)