Remove split_indicators from ChunkBatcher
#10583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
4 tasks
grtlr
added a commit
that referenced
this pull request
Jul 11, 2025
) ### Related * Part of #6889. * Closes #8129. * [x] Merge after #10583 * [x] Merge after #10581 ### What This removes the remaining reference to indicators from our codebase. Most notably this removes indicators from the dataframe queries and the UI. This should be fine because: * We drop indicator columns during Sorbet migration * By default indicators where not shown anyways * And they were omitted in queries by default too. > [!IMPORTANT] > There is some risk that this PR will make indicators appear again, so we should choose a good time to merge this PR. If they show up again then let's fix the root cause (i.e. migration logic). ### TODO * [x] full-check * [x] Dataplatform companion PR: rerun-io/dataplatform#1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
rerun_py, andrerun_cpp#10581.What
Removes unnecessary logic that would split a chunk into two if indicators were present. Also adds a check to
rerun rrd verifyfor indicator components.