Make it easier to disable the 3D line grid in Python (blueprint) #10621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7663993 to
c12f347
Compare
c12f347 to
976c907
Compare
ntjohnson1
approved these changes
Jul 15, 2025
| def __init__( | ||
| self: Any, | ||
| visible: datatypes.BoolLike | None = None, | ||
| *, |
There was a problem hiding this comment.
From a python perspective kwarg, *, more_kwargs looks a little weird but it looks like it works and wouldn't really break anything.
There was a problem hiding this comment.
My python isn't that amazing, how else would you do it?
There was a problem hiding this comment.
Generally in python we don't include the * and let people use positional or keywords args. We seem to use this pattern here rejecting positional args for convenience in wrapping things.
Short answer I'm not sure if we actually need the * to make the extensions work. If we do then this is totally reasonable with that context but a little weird since python typically doesn't allow positional arguments after keyword arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to turn off the 3D grid lines for one of our examples and found it a bit annoying to do. This makes it a lot easier:
Before:
After: