Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ntjohnson1
Copy link
Member

@ntjohnson1 ntjohnson1 commented Jul 16, 2025

Related

Closes #10658
Somewhat a follow up to #10647

What

  • I added a check for improper AnyValues usage (providing a value rather than kwarg) and that blew up the example since it was setup wrong
  • Debugging this issue I hit
    • Numpy arrays of non-numeric types don't work for dlpack (check for BufferError)
    • Empty AnyValues are valid when used later, so I narrowed my check
    • Add an additional check for empty batches since that combined with my narrow check should prevent foot guns
    • Update our unit tests to better cover this

@ntjohnson1 ntjohnson1 added 🪳 bug Something isn't working examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 16, 2025
@ntjohnson1 ntjohnson1 changed the title Nick/any value example AnyValues Edge Cases and Air Traffic Example Fix Jul 16, 2025
@Wumpf Wumpf self-requested a review July 16, 2025 12:23
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Member

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Wumpf Wumpf merged commit 7c4d986 into main Jul 16, 2025
48 of 49 checks passed
@Wumpf Wumpf deleted the nick/any_value_example branch July 16, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Air Traffic Data example is failing on local because of AnyValue type issue
3 participants