Fix breaking example in `rerun_notebook/example.ipynb` #10706

glk0 · 2025-07-18T18:02:52Z

    
           def __init__( 
        
               self, 
        
               *, 
        
               width: int | None = None, 
        
               height: int | None = None, 
        
               url: str | None = None, 
        
               panel_states: Mapping[Panel, PanelState] | None = None, 
        
               **kwargs: Any, 
        
           ) -> None:

The new signature

rerun/rerun_notebook/src/rerun_notebook/__init__.py

Lines 179 to 188 in a1bce51

    
           def __init__( 
        
               self, 
        
               *, 
        
               width: int | Literal["auto"], 
        
               height: int | Literal["auto"], 
        
               url: str | None = None, 
        
               panel_states: Mapping[Panel, PanelState] | None = None, 
        
               fallback_token: str | None = None, 
        
               **kwargs: Any, 
        
           ) -> None:

What

Fixes rerun_notebook/example.ipynb breaking due to reliance on older signature.

ntjohnson1

Thanks for contributing for the first time and for raising the other issue!

### Related Old signature of inialization of `Viewer` class: https://github.com/rerun-io/rerun/blob/82d45ce7de4334a64c52f14bff61fe030aa664b1/rerun_notebook/src/rerun_notebook/__init__.py#L177-L185 The new signature https://github.com/rerun-io/rerun/blob/a1bce5156d46c9d4c9e5610c46bcae47fd09acf4/rerun_notebook/src/rerun_notebook/__init__.py#L179-L188 ### What Fixes `rerun_notebook/example.ipynb` breaking due to reliance on older signature.

glk0 and others added 2 commits July 18, 2025 18:29

fix: update class initialization to use current signature

7719f36

Fix formatting before running CI

5bea0ad

ntjohnson1 added 🪳 bug Something isn't working notebook Jupyter notebooks etc include in changelog labels Jul 20, 2025

ntjohnson1 added this to the 0.24.1 (maybe) milestone Jul 20, 2025

ntjohnson1 mentioned this pull request Jul 20, 2025

Move Example Notebooks from rerun_notebooks to /examples #10711

Open

ntjohnson1 approved these changes Jul 20, 2025

View reviewed changes

ntjohnson1 merged commit 6b4dc41 into rerun-io:main Jul 20, 2025
40 of 41 checks passed

emilk changed the title ~~fix breaking example in rerun_notebook/example.ipynb~~ Fix breaking example in rerun_notebook/example.ipynb Aug 7, 2025

emilk changed the title ~~Fix breaking example in rerun_notebook/example.ipynb~~ Fix breaking example in rerun_notebook/example.ipynb Aug 7, 2025

emilk mentioned this pull request Aug 7, 2025

Release 0.24.1 #10808

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix breaking example in `rerun_notebook/example.ipynb` #10706

Fix breaking example in `rerun_notebook/example.ipynb` #10706

Uh oh!

glk0 commented Jul 18, 2025

Uh oh!

ntjohnson1 left a comment

Uh oh!

Uh oh!

Uh oh!

	def __init__(
	self,
	*,
	width: int \| None = None,
	height: int \| None = None,
	url: str \| None = None,
	panel_states: Mapping[Panel, PanelState] \| None = None,
	**kwargs: Any,
	) -> None:

	def __init__(
	self,
	*,
	width: int \| Literal["auto"],
	height: int \| Literal["auto"],
	url: str \| None = None,
	panel_states: Mapping[Panel, PanelState] \| None = None,
	fallback_token: str \| None = None,
	**kwargs: Any,
	) -> None:

Fix breaking example in rerun_notebook/example.ipynb #10706

Fix breaking example in rerun_notebook/example.ipynb #10706

Uh oh!

Conversation

glk0 commented Jul 18, 2025

Related

What

Uh oh!

ntjohnson1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Fix breaking example in `rerun_notebook/example.ipynb` #10706

Fix breaking example in `rerun_notebook/example.ipynb` #10706