Fix colors sometimes being wrong in plot view #10713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
a775b18 to
452367c
Compare
grtlr
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Nice!
This would be very valuable to have as a snapshot test, maybe based-off @jleibs's issue?
The scaffolding for this is quite minimal, here is an example: https://github.com/rerun-io/rerun/blob/main/crates/viewer/re_view_time_series/tests/basic.rs
c328bc1 to
15da4da
Compare
15da4da to
8d85f02
Compare
9753a2c to
9faadb0
Compare
grtlr
reviewed
Jul 23, 2025
grtlr
approved these changes
Jul 23, 2025
emilk
reviewed
Aug 4, 2025
| &re_types::archetypes::SeriesLines::new() | ||
| .with_widths([5.0]) | ||
| .with_colors([re_types::components::Color::from_rgb(255, 0, 255)]) | ||
| .with_names(["muh_scalars_from_45"]), |
There was a problem hiding this comment.
My typos complain about "muh". What does it mean?
emilk
pushed a commit
that referenced
this pull request
Aug 6, 2025
The plot view visualizes scalar data within a specific time range, without any kind of time-alignment / bootstrapping behavior: * For the scalar themselves, this is what you want: if you're trying to plot some data between t=100 and t=200, you don't want to display a point from t=20 (and _extended bounds_ will take care of lines crossing the limit). * For the secondary components (colors, radii, names, etc), this is a problem though: you don't want your plot to change color depending on what the currently visible time range is! Secondary components have to be bootstrapped. Before: https://github.com/user-attachments/assets/4ad5e448-e6a9-46ed-bb02-7c88cb8cd3d1 After: https://github.com/user-attachments/assets/03030ff5-d836-4e9f-9e70-2871c7afbdcc --------- Co-authored-by: Jochen Görtler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plot view visualizes scalar data within a specific time range, without any kind of time-alignment / bootstrapping behavior:
Before:
25-07-21_10.20.14.patched.mp4
After:
25-07-21_10.23.52.patched.mp4