Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make parking_lot dependency version stricter to prevent import failure #10732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Make parking_lot dependency version stricter to prevent import failure #10732

merged 1 commit into from
Jul 23, 2025

Conversation

sdd
Copy link
Contributor

@sdd sdd commented Jul 22, 2025 •
edited by grtlr
Loading

Related

What

re_chunk_store depends on parking_lot::ArcRwLockReadGuard which was only added in parking_lot 0.12.3, but the workspace Cargo.toml specifies the version dependency of parking_lot as 0.12

github-actions[bot]
github-actions bot reviewed Jul 22, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@grtlr grtlr changed the title make parking_lot dependency version stricter to prevent import failure Make parking_lot dependency version stricter to prevent import failure Jul 23, 2025
@grtlr grtlr added this to the 0.24.1 (maybe) milestone Jul 23, 2025
@grtlr grtlr changed the title Make parking_lot dependency version stricter to prevent import failure Make parking_lot dependency version stricter to prevent import failure Jul 23, 2025
@grtlr
Copy link
Member

grtlr commented Jul 23, 2025

Ah, great catch—sorry for this! Thank you for your issue and PR 🤩

@grtlr grtlr added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Jul 23, 2025
@grtlr grtlr merged commit 6218ab9 into rerun-io:main Jul 23, 2025
45 of 46 checks passed
emilk pushed a commit that referenced this pull request Aug 6, 2025
@sdd @emilk
Make parking_lot dependency version stricter to prevent import fail…
4c4deee 
…ure (#10732)

### Related

* Fixes #10731

### What

re_chunk_store depends on `parking_lot::ArcRwLockReadGuard` which was
only added in `parking_lot` 0.12.3, but the workspace Cargo.toml
specifies the version dependency of `parking_lot` as 0.12
@emilk emilk mentioned this pull request Aug 7, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Milestone
0.24.1 - bug fixes
Development

Successfully merging this pull request may close these issues.

Insufficiently strict version constraint on parking_lot
2 participants
@sdd @grtlr