Fix C++ interface for VideoStream
#10745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jleibs
reviewed
Jul 24, 2025
jleibs
approved these changes
Jul 24, 2025
I can't approve my own PR but your changes LGTM as well. |
emilk
pushed a commit
that referenced
this pull request
Aug 6, 2025
### What Our code gen treats all enums as uint8_t however they can be other types. In this instance we have a uint32_t and by shaving off that precision we get the fairly ambiguous `missing_union_arm` error. Reported on discord [here](https://discord.com/channels/1062300748202921994/1397335975364919392/1397335975364919392) but it means the VideoStream isn't available on C++ right now. ```console re_viewer_context::component_ui_registry] Failed to deserialize component of type rerun.components.VideoCodec: Failed to deserialize "rerun.components.VideoCodec" ``` See my first commit for the point fix then my second commit resolves this in code gen. --------- Co-authored-by: Jeremy Leibs <[email protected]>
VideoStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our code gen treats all enums as uint8_t however they can be other types. In this instance we have a uint32_t and by shaving off that precision we get the fairly ambiguous
missing_union_armerror. Reported on discord here but it means the VideoStream isn't available on C++ right now.re_viewer_context::component_ui_registry] Failed to deserialize component of type rerun.components.VideoCodec: Failed to deserialize "rerun.components.VideoCodec"See my first commit for the point fix then my second commit resolves this in code gen.