Make @rerun-io/web-viewer-react compatible with React 19
#10809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
Aug 6, 2025
| export default class WebViewer extends React.Component { | ||
| /** @type {React.RefObject<HTMLDivElement>} */ | ||
| #parent = createRef(); | ||
| #parent = /** @type {React.RefObject<HTMLDivElement>} */ (createRef()); |
There was a problem hiding this comment.
this annotation was the only thing that broke when switching to React 19. The fix is what the ai suggested and it seems to work just fine 🤷
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
grtlr
approved these changes
Aug 6, 2025
aedm
approved these changes
Aug 6, 2025
emilk
added a commit
that referenced
this pull request
Aug 6, 2025
* Fixes #10736 .. and use `peerDependencies` instead of `dependencies` as it is common practice in the ecosystem. Tested by building building with dev dependencies pointing to React 18 & 19 as well as a minimal example app using either react 18 or 19 and printing the active react version number: ```ts import WebViewer from "@rerun-io/web-viewer-react"; import React from "react"; function App() { console.log("React version:", React.version); return ( <div style={{ width: "100vw", height: "100vh" }}> <WebViewer width="800px" height="600px" rrd="https://app.rerun.io/version/0.24.0/examples/arkit_scenes.rrd" /> </div> ); } export default App; ``` with either ```json "dependencies": { "@rerun-io/web-viewer-react": "file:../rerun/rerun_js/web-viewer-react", "react": "^18.3.1", "react-dom": "^18.3.1" }, ``` or ```json "dependencies": { "@rerun-io/web-viewer-react": "file:../rerun/rerun_js/web-viewer-react", "react": "^19.0.0", "react-dom": "^19.0.0" }, ``` --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
.. and use
peerDependenciesinstead ofdependenciesas it is common practice in the ecosystem.Tested by building building with dev dependencies pointing to React 18 & 19 as well as a minimal example app using either react 18 or 19 and printing the active react version number:
with either
or